Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History and logging #105

Merged
merged 2 commits into from
Apr 23, 2019
Merged

History and logging #105

merged 2 commits into from
Apr 23, 2019

Conversation

ccnifo
Copy link
Collaborator

@ccnifo ccnifo commented Feb 22, 2019

This PR has 2 distinct goals, but aims at the same schedd config file:

  • 1st commit makes the history rotation parameters customizable. This can be important for sites relying on these files for their accounting
  • 2nd commit just evicts logging parameters from this file, in case log_to_syslog is applied (because in this case they do not apply but may confuse the admin looking at the conf).

@kreczko
Copy link
Member

kreczko commented Feb 25, 2019

LGTM.
I guess we merge it after #104 ?

@ccnifo
Copy link
Collaborator Author

ccnifo commented Feb 25, 2019

Distinct branches with no conflict: the order doesn't matter, except if you prefer to have green Travis tests for this PR.

@kreczko kreczko merged commit 1d6d2b2 into HEP-Puppet:master Apr 23, 2019
@ccnifo ccnifo deleted the history_and_logging branch May 15, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccnifo @kreczko