Custom logging manifest #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccnifo
force-pushed
the
logging_parameters
branch
from
8e31040 to
8315dcc
Compare
|
Thanks a lot for the contribution. |
|
Here it is, a hash "param=>value" to take any valid condor parameter/value. |
|
Thanks! |
ccnifo
commented
May 2, 2018
README.md
Outdated
| If you want HTCondor to use custom logging parameters, you may specify `use_custom_logs` and the `logging_parameters` hash with the `{parameter_name => desired_value}` form. For example: | ||
| ``` | ||
| use_custom_logs => true, | ||
| $logging_parameters => { 'SCHEDD_DEBUG' => 'D_NETWORK,D_PROTOCOL', NEGOTIATOR_DEBUG' => 'D_FULLDEBUG', ... } |
There was a problem hiding this comment.
Just saw a typo: $logging_parameters should be just logging_parameters. Sorry for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this PR to add a manifest introducing logs customization.
For now, it is just the
LOG_TO_SYSLOGparameter, because it's a highly valuable parameter for some log monitoring systems, but could be extended.I took this chance to replace anchors with contain (compatible with Puppet >= 3.4.0).
Given that logging may have many different configurations, I was wondering if this solution wouldn't be interesting:
having a hash,
{ param1=value1, param2=value2 }to add to the logging template. That would, for example, allow someone to writeAnd in the end, this would be cleanly listed in the
/etc/condor/config.d/14_logging.config.If you agree that's a good change, I will add a commit with this change.