Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #1

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add Dockerfile #1

wants to merge 14 commits into from

Conversation

antavent-com
Copy link

and a few other files to help create and run the playground in a docker container.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ JoshuaBehrens
❌ selter01279
You have signed the CLA already but the status is still pending? Let us recheck it.

@JoshuaBehrens JoshuaBehrens added enhancement New feature or request good first issue Good for newcomers labels Jul 21, 2021
Dockerfile Outdated
RUN runuser -u www-data -- make --directory=/var/www/html shopware-platform-files

RUN pecl install xdebug-2.9.8;\
docker-php-ext-enable xdebug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are thinking about a base image to speed up the build process. Do you think, it would be a good idea to move this RUN a bit higher? I suggest to put this right behind the COPY for composer. Then all the steps up to this can be extracted into a new image.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the fact that the Playground project is not made for productive use, I think it's OK using Xdebug for the base image. Then Xdebug can also be installed in the layer directly after the COPY for Composer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the docker container reference to the versioned container matching the release of 0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging this pull request may close these issues.

5 participants