-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile #1
base: master
Are you sure you want to change the base?
Conversation
…round in a docker container.
|
Dockerfile
Outdated
RUN runuser -u www-data -- make --directory=/var/www/html shopware-platform-files | ||
|
||
RUN pecl install xdebug-2.9.8;\ | ||
docker-php-ext-enable xdebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are thinking about a base image to speed up the build process. Do you think, it would be a good idea to move this RUN a bit higher? I suggest to put this right behind the COPY for composer. Then all the steps up to this can be extracted into a new image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the fact that the Playground project is not made for productive use, I think it's OK using Xdebug for the base image. Then Xdebug can also be installed in the layer directly after the COPY for Composer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the docker container reference to the versioned container matching the release of 0.6
# Conflicts: # Makefile
…ware-platform-files' to prepare playground
…latform/composer.lock use new base image heptacom/heptaconnect-development:php80-0.8.0 (uses PHP 8 and XDebug 3.0) add example to change environment variables by docker-compose.yml.dist add example for using XDebug 3.0 in docker-compose.yml.dist
and a few other files to help create and run the playground in a docker container.