Bump numpy version #397
Merged
Bump numpy version #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that the numpy version used to build hexrd is compatible with numba. We should test this to be sure it works... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
The latest numba, 0.55, which was released a few weeks ago, is compatible with numpy 1.21, but not numpy 1.22. Bump the maximum numpy version to 1.21 to reflect this. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Otherwise, it is defaulting to 1.16 with this message in the log files: ``` No numpy version specified in conda_build_config.yaml. Falling back to default numpy value of 1.16 WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml. Falling back to default numpy value of 1.16 ``` Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
I tested this out locally on Linux with one of the examples and it seems to be working. |
joelvbernier
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest numba, 0.55, which was released a few weeks ago, is
compatible with numpy 1.21, but not numpy 1.22.
Bump the maximum numpy version to 1.21 to reflect this.
This is to ensure that the numpy version used to build hexrd is
compatible with numba.
We should test this to be sure it works...