Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nfutil.py #408

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Update nfutil.py #408

merged 1 commit into from
Mar 11, 2022

Conversation

darrencpagan
Copy link
Contributor

Update output_grain_map to take volume offsets and combines functionality to output as npz, hdf5, or vtk.

Update output_grain_map to take volume offsets and combines functionality to output as npz, hdf5, or vtk.
@pep8speaks
Copy link

Hello @darrencpagan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1573:1: E302 expected 2 blank lines, found 1
Line 1573:35: E231 missing whitespace after ','
Line 1573:46: E231 missing whitespace after ','
Line 1573:58: E231 missing whitespace after ','
Line 1573:70: E231 missing whitespace after ','
Line 1573:80: E501 line too long (103 > 79 characters)
Line 1573:84: E231 missing whitespace after ','
Line 1575:14: E225 missing whitespace around operator
Line 1576:1: W293 blank line contains whitespace
Line 1577:20: E225 missing whitespace around operator
Line 1578:15: E225 missing whitespace around operator
Line 1579:8: E225 missing whitespace around operator
Line 1580:8: E225 missing whitespace around operator
Line 1581:8: E225 missing whitespace around operator
Line 1582:1: W293 blank line contains whitespace
Line 1583:24: E225 missing whitespace around operator
Line 1584:19: E225 missing whitespace around operator
Line 1584:31: E231 missing whitespace after ','
Line 1584:62: E231 missing whitespace after ','
Line 1586:19: E225 missing whitespace around operator
Line 1587:1: W293 blank line contains whitespace
Line 1588:1: W293 blank line contains whitespace
Line 1589:5: E303 too many blank lines (2)
Line 1590:39: E228 missing whitespace around modulo operator
Line 1591:18: E225 missing whitespace around operator
Line 1591:53: E231 missing whitespace after ','
Line 1591:80: E501 line too long (91 > 79 characters)
Line 1592:1: W293 blank line contains whitespace
Line 1593:28: E225 missing whitespace around operator
Line 1594:23: E225 missing whitespace around operator
Line 1595:16: E225 missing whitespace around operator
Line 1596:16: E225 missing whitespace around operator
Line 1597:16: E225 missing whitespace around operator
Line 1598:1: W293 blank line contains whitespace
Line 1599:5: E265 block comment should start with '# '
Line 1600:15: E225 missing whitespace around operator
Line 1601:1: W293 blank line contains whitespace
Line 1602:17: E225 missing whitespace around operator
Line 1603:1: W293 blank line contains whitespace
Line 1604:13: E225 missing whitespace around operator
Line 1605:13: E225 missing whitespace around operator
Line 1606:1: W293 blank line contains whitespace
Line 1607:23: E225 missing whitespace around operator
Line 1607:46: E231 missing whitespace after ','
Line 1607:55: E231 missing whitespace after ','
Line 1608:24: E225 missing whitespace around operator
Line 1608:47: E231 missing whitespace after ','
Line 1608:56: E231 missing whitespace after ','
Line 1609:16: E225 missing whitespace around operator
Line 1609:39: E231 missing whitespace after ','
Line 1609:48: E231 missing whitespace after ','
Line 1610:16: E225 missing whitespace around operator
Line 1610:39: E231 missing whitespace after ','
Line 1610:48: E231 missing whitespace after ','
Line 1611:16: E225 missing whitespace around operator
Line 1611:39: E231 missing whitespace after ','
Line 1611:48: E231 missing whitespace after ','
Line 1612:1: W293 blank line contains whitespace
Line 1613:1: W293 blank line contains whitespace
Line 1614:5: E303 too many blank lines (2)
Line 1615:20: E225 missing whitespace around operator
Line 1615:20: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1616:78: E231 missing whitespace after ','
Line 1616:80: E231 missing whitespace after ','
Line 1616:80: E501 line too long (109 > 79 characters)
Line 1616:83: E225 missing whitespace around operator
Line 1617:79: E231 missing whitespace after ','
Line 1617:80: E501 line too long (115 > 79 characters)
Line 1617:81: E231 missing whitespace after ','
Line 1617:84: E225 missing whitespace around operator
Line 1618:71: E231 missing whitespace after ','
Line 1618:73: E231 missing whitespace after ','
Line 1618:76: E225 missing whitespace around operator
Line 1620:71: E231 missing whitespace after ','
Line 1620:73: E231 missing whitespace after ','
Line 1620:76: E225 missing whitespace around operator
Line 1622:71: E231 missing whitespace after ','
Line 1622:73: E231 missing whitespace after ','
Line 1622:76: E225 missing whitespace around operator
Line 1622:80: E501 line too long (110 > 79 characters)
Line 1622:111: W291 trailing whitespace
Line 1624:1: W293 blank line contains whitespace
Line 1625:78: E231 missing whitespace after ','
Line 1625:80: E231 missing whitespace after ','
Line 1625:80: E501 line too long (97 > 79 characters)
Line 1625:83: E225 missing whitespace around operator
Line 1626:79: E231 missing whitespace after ','
Line 1626:80: E501 line too long (103 > 79 characters)
Line 1626:81: E231 missing whitespace after ','
Line 1626:84: E225 missing whitespace around operator
Line 1627:71: E231 missing whitespace after ','
Line 1627:73: E231 missing whitespace after ','
Line 1627:76: E225 missing whitespace around operator
Line 1627:80: E501 line too long (83 > 79 characters)
Line 1628:71: E231 missing whitespace after ','
Line 1628:73: E231 missing whitespace after ','
Line 1628:76: E225 missing whitespace around operator
Line 1628:80: E501 line too long (83 > 79 characters)
Line 1629:71: E231 missing whitespace after ','
Line 1629:73: E231 missing whitespace after ','
Line 1629:76: E225 missing whitespace around operator
Line 1629:80: E501 line too long (98 > 79 characters)
Line 1630:1: W293 blank line contains whitespace
Line 1632:1: W293 blank line contains whitespace
Line 1634:1: W293 blank line contains whitespace
Line 1636:1: W293 blank line contains whitespace
Line 1643:1: W293 blank line contains whitespace
Line 1644:27: E225 missing whitespace around operator
Line 1645:1: W293 blank line contains whitespace
Line 1648:53: E502 the backslash is redundant between brackets
Line 1649:14: E128 continuation line under-indented for visual indent
Line 1649:42: E231 missing whitespace after ','
Line 1650:14: E128 continuation line under-indented for visual indent
Line 1650:28: E231 missing whitespace after ','
Line 1650:43: E231 missing whitespace after ','
Line 1651:1: W293 blank line contains whitespace
Line 1652:27: E225 missing whitespace around operator
Line 1653:1: W293 blank line contains whitespace
Line 1654:1: W293 blank line contains whitespace
Line 1655:13: E303 too many blank lines (2)
Line 1656:23: W291 trailing whitespace
Line 1657:19: E225 missing whitespace around operator
Line 1657:33: E231 missing whitespace after ','
Line 1657:35: E231 missing whitespace after ','
Line 1658:19: E225 missing whitespace around operator
Line 1658:33: E231 missing whitespace after ','
Line 1658:35: E231 missing whitespace after ','
Line 1659:19: E225 missing whitespace around operator
Line 1659:33: E231 missing whitespace after ','
Line 1659:35: E231 missing whitespace after ','
Line 1660:1: W293 blank line contains whitespace
Line 1661:22: E225 missing whitespace around operator
Line 1661:43: E231 missing whitespace after ','
Line 1661:45: E231 missing whitespace after ','
Line 1662:21: E225 missing whitespace around operator
Line 1662:43: E231 missing whitespace after ','
Line 1662:45: E231 missing whitespace after ','
Line 1663:1: W293 blank line contains whitespace
Line 1664:20: E225 missing whitespace around operator
Line 1665:22: E225 missing whitespace around operator
Line 1666:1: W293 blank line contains whitespace
Line 1667:48: E225 missing whitespace around operator
Line 1668:1: W293 blank line contains whitespace
Line 1669:1: W293 blank line contains whitespace
Line 1670:13: E303 too many blank lines (2)
Line 1675:1: W293 blank line contains whitespace
Line 1677:40: E225 missing whitespace around operator
Line 1677:50: E231 missing whitespace after ','
Line 1677:60: E231 missing whitespace after ','
Line 1678:1: W293 blank line contains whitespace
Line 1679:19: E225 missing whitespace around operator
Line 1680:19: E225 missing whitespace around operator
Line 1680:28: W291 trailing whitespace
Line 1681:1: W293 blank line contains whitespace
Line 1682:64: W291 trailing whitespace
Line 1686:29: E225 missing whitespace around operator
Line 1686:49: W291 trailing whitespace
Line 1687:27: E225 missing whitespace around operator
Line 1688:27: E225 missing whitespace around operator
Line 1689:27: E225 missing whitespace around operator
Line 1690:27: E225 missing whitespace around operator
Line 1691:27: E225 missing whitespace around operator
Line 1692:27: E225 missing whitespace around operator
Line 1693:27: E225 missing whitespace around operator
Line 1694:27: E225 missing whitespace around operator
Line 1695:1: W293 blank line contains whitespace
Line 1696:64: E502 the backslash is redundant between brackets
Line 1697:34: E225 missing whitespace around operator
Line 1697:37: E231 missing whitespace after ','
Line 1697:40: E231 missing whitespace after ','
Line 1697:43: E231 missing whitespace after ','
Line 1697:46: E231 missing whitespace after ','
Line 1697:49: E231 missing whitespace after ','
Line 1697:52: E231 missing whitespace after ','
Line 1697:55: E231 missing whitespace after ','
Line 1697:60: W291 trailing whitespace
Line 1698:1: W293 blank line contains whitespace
Line 1699:1: W293 blank line contains whitespace
Line 1700:13: E303 too many blank lines (2)
Line 1700:54: W291 trailing whitespace
Line 1702:33: W291 trailing whitespace
Line 1703:1: W293 blank line contains whitespace
Line 1705:47: W291 trailing whitespace
Line 1706:47: W291 trailing whitespace
Line 1708:34: E225 missing whitespace around operator
Line 1708:49: W291 trailing whitespace
Line 1709:1: W293 blank line contains whitespace
Line 1710:43: E202 whitespace before ')'
Line 1711:60: W291 trailing whitespace
Line 1713:34: E225 missing whitespace around operator
Line 1713:48: W291 trailing whitespace
Line 1714:1: W293 blank line contains whitespace
Line 1715:1: W293 blank line contains whitespace
Line 1716:13: E303 too many blank lines (2)
Line 1717:1: W293 blank line contains whitespace
Line 1720:1: W293 blank line contains whitespace
Line 1722:13: E127 continuation line over-indented for visual indent

@joelvbernier joelvbernier merged commit 0d2c956 into HEXRD:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants