Update spectrum fitting utils to support wildcards in parameter name matching #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance parameter name matching to take wildcards.
joelvbernier
added
documentation
|
This needs a little more work, since it will only supports wildcard strings now... either I live with it or find a way to preserve (or choose by kwarg?) the old functionality using Any ideas here @psavery or @cjh1 or @donald-e-boyce ? |
psavery
reviewed
Aug 6, 2022
joelvbernier
changed the title
|
@psavery -- I think the previous commit is providing the behavior we want! Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance parameter name matching to take wildcards.