Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF chunking #461

Merged
merged 5 commits into from
Sep 2, 2022
Merged

NF chunking #461

merged 5 commits into from
Sep 2, 2022

Conversation

rachelelim
Copy link
Contributor

Made edits to process_nf.py script to calculate groups to process based on a maximum RAM (user input). Changed raw confidence processing to not reshape until all groups have been tested.

@pep8speaks
Copy link

pep8speaks commented Aug 11, 2022

Hello @rachelelim! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1328:1: E302 expected 2 blank lines, found 1
Line 1328:42: E231 missing whitespace after ','
Line 1328:57: E231 missing whitespace after ','
Line 1328:71: E231 missing whitespace after ','
Line 1328:80: E501 line too long (87 > 79 characters)
Line 1331:18: E711 comparison to None should be 'if cond is None:'
Line 1332:23: E225 missing whitespace around operator
Line 1332:45: E231 missing whitespace after ','
Line 1333:18: E225 missing whitespace around operator
Line 1333:43: E231 missing whitespace after ','
Line 1335:23: E225 missing whitespace around operator
Line 1335:45: E231 missing whitespace after ','
Line 1336:18: E225 missing whitespace around operator
Line 1336:43: E231 missing whitespace after ','

Line 129:14: E261 at least two spaces before inline comment
Line 129:15: E262 inline comment should start with '# '
Line 211:1: E265 block comment should start with '# '
Line 213:1: E265 block comment should start with '# '
Line 230:64: E225 missing whitespace around operator
Line 230:78: E231 missing whitespace after ','
Line 230:80: E501 line too long (99 > 79 characters)
Line 233:1: E128 continuation line under-indented for visual indent
Line 233:15: E251 unexpected spaces around keyword / parameter equals
Line 233:17: E251 unexpected spaces around keyword / parameter equals
Line 235:1: E128 continuation line under-indented for visual indent
Line 235:17: E251 unexpected spaces around keyword / parameter equals
Line 235:19: E251 unexpected spaces around keyword / parameter equals
Line 235:43: W291 trailing whitespace
Line 259:1: E128 continuation line under-indented for visual indent
Line 259:1: E265 block comment should start with '# '
Line 262:1: E128 continuation line under-indented for visual indent
Line 263:5: E128 continuation line under-indented for visual indent
Line 263:19: E251 unexpected spaces around keyword / parameter equals
Line 263:21: E251 unexpected spaces around keyword / parameter equals
Line 264:80: E501 line too long (85 > 79 characters)
Line 266:5: E128 continuation line under-indented for visual indent
Line 268:5: E128 continuation line under-indented for visual indent
Line 268:24: E251 unexpected spaces around keyword / parameter equals
Line 268:26: E251 unexpected spaces around keyword / parameter equals
Line 271:5: E128 continuation line under-indented for visual indent
Line 272:40: E251 unexpected spaces around keyword / parameter equals
Line 272:42: E251 unexpected spaces around keyword / parameter equals
Line 275:1: E128 continuation line under-indented for visual indent
Line 277:5: E128 continuation line under-indented for visual indent
Line 277:19: E251 unexpected spaces around keyword / parameter equals
Line 277:21: E251 unexpected spaces around keyword / parameter equals
Line 278:5: E128 continuation line under-indented for visual indent
Line 278:24: E251 unexpected spaces around keyword / parameter equals
Line 278:26: E251 unexpected spaces around keyword / parameter equals
Line 280:5: E128 continuation line under-indented for visual indent
Line 281:5: E128 continuation line under-indented for visual indent
Line 282:23: E251 unexpected spaces around keyword / parameter equals
Line 282:25: E251 unexpected spaces around keyword / parameter equals
Line 283:80: E501 line too long (83 > 79 characters)
Line 285:23: E251 unexpected spaces around keyword / parameter equals
Line 285:25: E251 unexpected spaces around keyword / parameter equals
Line 286:80: E501 line too long (94 > 79 characters)
Line 288:56: E251 unexpected spaces around keyword / parameter equals
Line 288:58: E251 unexpected spaces around keyword / parameter equals
Line 288:80: E501 line too long (88 > 79 characters)
Line 292:80: E501 line too long (103 > 79 characters)
Line 292:81: E251 unexpected spaces around keyword / parameter equals
Line 292:83: E251 unexpected spaces around keyword / parameter equals
Line 295:80: E501 line too long (108 > 79 characters)
Line 295:81: E251 unexpected spaces around keyword / parameter equals
Line 295:83: E251 unexpected spaces around keyword / parameter equals
Line 297:5: E128 continuation line under-indented for visual indent
Line 297:5: E265 block comment should start with '# '
Line 298:5: E128 continuation line under-indented for visual indent
Line 298:19: E251 unexpected spaces around keyword / parameter equals
Line 298:21: E251 unexpected spaces around keyword / parameter equals
Line 300:5: E128 continuation line under-indented for visual indent
Line 300:19: E251 unexpected spaces around keyword / parameter equals
Line 300:21: E251 unexpected spaces around keyword / parameter equals
Line 301:80: E501 line too long (90 > 79 characters)
Line 302:5: E128 continuation line under-indented for visual indent
Line 302:52: E251 unexpected spaces around keyword / parameter equals
Line 302:54: E251 unexpected spaces around keyword / parameter equals
Line 302:80: E501 line too long (84 > 79 characters)
Line 305:5: E128 continuation line under-indented for visual indent
Line 306:44: E251 unexpected spaces around keyword / parameter equals
Line 306:46: E251 unexpected spaces around keyword / parameter equals
Line 308:5: E128 continuation line under-indented for visual indent
Line 309:44: E251 unexpected spaces around keyword / parameter equals
Line 309:46: E251 unexpected spaces around keyword / parameter equals
Line 310:1: W293 blank line contains whitespace
Line 311:5: E128 continuation line under-indented for visual indent
Line 311:5: E265 block comment should start with '# '
Line 312:5: E128 continuation line under-indented for visual indent
Line 312:14: E251 unexpected spaces around keyword / parameter equals
Line 312:16: E251 unexpected spaces around keyword / parameter equals
Line 313:5: E128 continuation line under-indented for visual indent
Line 313:19: E251 unexpected spaces around keyword / parameter equals
Line 313:21: E251 unexpected spaces around keyword / parameter equals
Line 317:1: E128 continuation line under-indented for visual indent
Line 317:15: W291 trailing whitespace
Line 318:1: W293 blank line contains whitespace

Comment last updated at 2022-09-01 14:08:46 UTC

@joelvbernier joelvbernier mentioned this pull request Sep 2, 2022
@joelvbernier joelvbernier self-requested a review September 2, 2022 19:49
@joelvbernier joelvbernier merged commit 6d9f2d1 into HEXRD:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants