Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch auto cal to import from hexrd #1160

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Conversation

joelvbernier
Copy link
Member

@joelvbernier joelvbernier commented Feb 15, 2022

This is a running patch to now import the simple auto calibrators from hexrd.fitting.calibration, which now has an updated backend that implements lmfit. These are prototype classed for what we will move towards. We do, however, have users with a time-sensitive need to get this implemented as is. Some tasks I need your help with @psavery:

  • add options for new peak types for the auto calibrator ('split_pvoigt', 'pink_beam_dcs')
  • add selector for background function order (0-5, linear-quintic Chebyshev)
  • add bg_type key in HexrdConfig().config['calibration']['powder'] for selective bg order
  • improve logging from InstrumentCalibrator to use logging rather than print and clean up formatting.
  • make better use of and capture tqdm updates to hand GUI status bar?

@joelvbernier joelvbernier added enhancement New feature or request high priority Try to get as highest priority labels Feb 15, 2022
@joelvbernier joelvbernier requested a review from psavery February 15, 2022 19:22
@joelvbernier joelvbernier self-assigned this Feb 15, 2022
We are now using the ones in hexrd...

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This also re-organizes the peak fit type and background type to get
their options from lists that will, at some point, be in hexrd.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery
Copy link
Collaborator

psavery commented Feb 15, 2022

The fourth checkbox is fixed by HEXRD/hexrd#402

In the console, '\r' causes the cursor to go to the beginning of the
line. This is what tools like `tqdm` use in order to update a status
bar.

Add support for '\r' by going back to the beginning of the line in the
text edit when '\r' is encountered.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@joelvbernier joelvbernier merged commit 306f4c3 into master Feb 16, 2022
@joelvbernier joelvbernier deleted the calibrator-updates branch February 16, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Try to get as highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants