Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dock overlay mgr #1565

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Dock overlay mgr #1565

merged 2 commits into from
Sep 2, 2023

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Aug 28, 2023

Fixes #1564

@bnmajor bnmajor force-pushed the dock-overlay-mgr branch 2 times, most recently from e372aaf to 1489094 Compare August 28, 2023 15:26
@bnmajor
Migrate Overlay Manager from Dialog to DockWidget
960dac0 
Signed-off-by: Brianna Major <brianna.major@kitware.com>
@bnmajor
Make sure the widget can be docked
97d15cd 
Signed-off-by: Brianna Major <brianna.major@kitware.com>
saransh13
saransh13 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I especially like how it only docks on the left.

psavery
psavery approved these changes Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this, but the code changes look good to me.

@psavery psavery merged commit d30ac39 into HEXRD:master Sep 2, 2023
9 checks passed
@psavery psavery deleted the dock-overlay-mgr branch September 2, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saransh13 saransh13 saransh13 approved these changes

@psavery psavery psavery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dock overlay manager
3 participants
@bnmajor @psavery @saransh13