Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to mirror "Vary" from first detector in Calibration Dialog #1725

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Aug 20, 2024

This is significantly helpful in cases like the 32 subpanel Eiger system,
so that users do not need to click "Vary" checkboxes for every single detector,
if they are changing them in the same way.

tmp.mp4

Fixes: #1724

Believe it or not, expanding the rows in the QTreeView was taking a
*significant* amount of time. For the 32-subpanel eiger, it took nearly
10 seconds on my system!

Newer versions of Qt came with a `expandRecursively()` function that is
much faster. Use this when we can. The speedup is significant.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This is significantly helpful in cases like the 32 subpanel Eiger system,
so that users do not need to click "Vary" checkboxes for every single detector,
if they are changing them in the same way.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery requested a review from saransh13 August 20, 2024 18:39
Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psavery psavery merged commit ba5848e into master Aug 20, 2024
9 checks passed
@psavery psavery deleted the calibration-mirror-first-detector branch August 20, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Mirror First Detector" button to calibration workflow dialog
2 participants