Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Hookup input query, filters, sortby to live API calls #1492

Closed
rylew1 opened this issue Mar 18, 2024 · 1 comment · Fixed by #1501
Closed

[Task]: Hookup input query, filters, sortby to live API calls #1492

rylew1 opened this issue Mar 18, 2024 · 1 comment · Fixed by #1501
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets
Milestone
Search UI - Creat...

Comments

@rylew1
Copy link
Contributor

rylew1 commented Mar 18, 2024

Summary

Currently only the pagination page is hooked up to the live API

  • input query - not working on API yet
  • filters - should be working
  • order by - working for some but not all

We will be deferring error management work, so the user can have bad input if they put something malformed in the URL . Believe malformed input won't currently cause an error, it just won't change the search results.

Acceptance criteria

  • All user inputs are passed to the API (with only some actually working)
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Mar 18, 2024
@rylew1 rylew1 self-assigned this Mar 18, 2024
@rylew1 rylew1 mentioned this issue Mar 19, 2024
Merged
@sumiat sumiat mentioned this issue Mar 19, 2024
Closed
rylew1 added a commit that referenced this issue Mar 19, 2024
@rylew1
[Issue #1492]: Hook up rest of inputs to live API (#1501)
74c9480 
Fixes #1492

- Hook up filters (`status`, `agency`, `fundingInstrument`), query
search term, and `sortby` to live API calls
- Formatting done in `SearchOpportunityAPI` to build the proper request
body
@rylew1 rylew1 reopened this Mar 20, 2024
@rylew1
Copy link
Contributor Author

rylew1 commented Mar 20, 2024

reopen for the pagination bug

@rylew1 rylew1 closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler Grants Sprint Planning
Status: Done
Milestone
Search UI - Create initial search page
Development

Successfully merging a pull request may close this issue.

[Issue #1492]: Hook up rest of inputs to live API HHS/simpler-grants-gov
1 participant
@rylew1