-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Fix pagination reset issue #1505
Comments
cc @andycochran - if you have a moment, double check that the criteria above makes sense for a "pagination reset". Note that the API call for search results will be grabbing page 1 of the new results if we see this condition (not the page that was previously selected) |
Refined this a bit. Lemme know if it makes sense to you. |
@andycochran if |
IDK if that really matters. Aren't |
Summary
Problem: If the number of pages reduces when query parameters are changed, it is possible for the currently viewed page number to be higher than the new query's max number of pages.
Solution: Regardless of which page number the user is currently viewing, when they change any status, filter, query terms, or sorting option, the UI should:
page_offset
reset to 1Secondary problem: The pagination state also has to be lifted to fix the top and bottom pagination being out of sync
Acceptance criteria
The text was updated successfully, but these errors were encountered: