[Issue #1469] Add Funding Opp component w/ stubbed markup #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
reviewed
Mar 12, 2024
| name={option.id} | ||
| label={option.label} | ||
| // onChange={(e) => handleCheck(option.value, e.target.checked)} | ||
| // disabled={!mounted} // Required to be disabled until hydrated so query params are updated properly |
rylew1
reviewed
Mar 12, 2024
| <div className="grid-col-fill text-right"> | ||
| <button className="usa-button usa-button--unstyled font-sans-xs"> | ||
| Clear All | ||
| </button> |
There was a problem hiding this comment.
Were you planning to handle the select and clear ina separate pr?
There was a problem hiding this comment.
Yeah. I wasn't handling any functionality here. Just getting the scaffolding in there.
rylew1
approved these changes
Mar 12, 2024
andycochran
changed the title
andycochran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1469
Time to review: 5 mins
Changes proposed
SearchFundingOpportunitycomponentContext for reviewers
This just stubs in the markup. Still needs to be hooked up so it functions
Additional information