Create Alert for Errors in API Application Logs #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
approved these changes
Mar 26, 2024
infra/modules/monitoring/main.tf
Outdated
| resource "aws_cloudwatch_log_metric_filter" "service_error_filter" { | ||
|
|
||
| name = "service-error-filter" | ||
| pattern = "%ERROR%" # pattern can find events in unstructured logs |
There was a problem hiding this comment.
⭐⭐ (optional but seriously consider)
Nice! It this a regex? Can we update it to (ERROR|Exception)?
I feel like exception is more commonly going to be in the message than error is. In python, at least
There was a problem hiding this comment.
It is! I found this which was super helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1033
Time to review: x mins
Changes proposed
Context for reviewers
Additional information
Metric filter from the cloudwatch log group side:
the alarm:
