[Issue #1489] Complete search filter accordion logic #1490
Conversation
rylew1
requested review from
andycochran,
acouch and
SammySteiner
as code owners
| @@ -25,6 +29,7 @@ const FilterCheckbox: React.FC<FilterCheckboxProps> = ({ | |||
| onChange={onChange} | |||
| disabled={disabled} | |||
| checked={checked} | |||
| value={value || ""} | |||
There was a problem hiding this comment.
Allow a value to be passed in case we want to explicitly have a value set for checkbox submissions on search
Without this it's just { name: "status-forecased", value: "on"}
| initialQueryParams, | ||
| queryParamKey, | ||
| formRef, | ||
| ); |
There was a problem hiding this comment.
More logic was added to useSearchFilter since the SearchFilterAccordion is getting sizeable
| onClick={(event) => { | ||
| event.preventDefault(); | ||
| onClearAll?.(); | ||
| }} |
There was a problem hiding this comment.
select all/clear all options need to prevent form submit. The actual query param update and form submit happens together in useSearchFilter
| @@ -1,21 +1,47 @@ | |||
| "use client"; | |||
|
|
|||
There was a problem hiding this comment.
The name of this file might be better as useSearchFilterAccordion (if it's not also being used for opportunity status checkboxes - it would need to be refactored a bit for that) - but no pressing need to change the filename
| @@ -1,6 +1,6 @@ | |||
| "use client"; | |||
|
|
|||
There was a problem hiding this comment.
Explicitly mark all these files as use client so its clear
rylew1
changed the title
| fundingInstrument: fundingInstrumentQueryParams, | ||
| } = requestURLQueryParams; | ||
|
|
||
| // TODO: move this to server-side calculation? |
There was a problem hiding this comment.
I think that's right; the frontend shouldn't be responsible for this. It seems like the API should return an error if we request something specific from the API that doesn't exist.
rylew1
deleted the
rylew/1489-query-param-for-agency-and-funding-instrument-filters
branch
Summary
Fixes #1489
Time to review: 10-15 minutes
Changes proposed
useSearchFormStatethat wraps the new ReactuseFormStateuse clientDemo
Screen.Recording.2024-03-18.at.7.28.22.AM.mov