Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1400] Close issues in done column #1533

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Mar 25, 2024

Summary

Sets up GitHub action to automatically close issues that are in the "Done" column in our Sprint Board project but are still open in the repo.

Changes proposed

What was added, updated, or removed in this PR.

  • Creates a .github/linters/ sub-directory to store custom linters for the project
  • Adds a README to explain the purpose of that sub-directory
  • Creates a .github/linters/scripts/ sub-directory that stores custom scripts used by the linters
  • Creates a .github/linters/queries/ sub-directory that stores graphql queries used by the linters
  • Creates linters/scripts/close-issues-in-done-col.sh which closes issues in the done column
  • Creates a .github/workflows/ci-project-linters.yml which does a dry run of all project linters
  • Creates a .github/workflows/lint-close-done-issues.yml which runs all of the project linters on a schedule

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Output from the dry run:

Screenshot 2024-03-25 at 2 40 50 PM

Which matches the list of tickets that are "Done" but still open:

Screenshot 2024-03-25 at 12 26 33 PM

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 25, 2024
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's just a stray comment

.github/workflows/lint-close-done-issues.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@sumiat sumiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying how often this happens - linter runs once a day at midnight ET! how it will work LGTM!

@github-actions github-actions bot removed documentation Improvements or additions to documentation shell labels Mar 26, 2024
@widal001 widal001 merged commit 8bea3cb into main Mar 26, 2024
8 checks passed
@widal001 widal001 deleted the issue-1400-close-issues-in-done-col branch March 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: GitHub action to auto-close tickets that are "done" in Sprint Board
4 participants