[Issue #1535] Adds analytics postgres DB #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Mar 25, 2024
| @@ -0,0 +1,103 @@ | |||
| # docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc | |||
There was a problem hiding this comment.
Copied from infra/api/database/main.tf
coilysiren
changed the title
coilysiren
commented
Mar 25, 2024
| @@ -0,0 +1,23 @@ | |||
| locals { | |||
There was a problem hiding this comment.
copied from infra/api/app-config/env-config/environment-variables.tf
coilysiren
commented
Mar 25, 2024
| @@ -0,0 +1,54 @@ | |||
| locals { | |||
There was a problem hiding this comment.
copied from infra/api/app-config/main.tf
coilysiren
changed the title
aplybeah
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1535
Time to review: 5 mins
Changes proposed
infra/analyticsinfra/analytics/database/main.tf, which creates the databaseNotes for Reviewers
This PR contains a lot of boilerplate because of needing the app-config / env-config changes. Sorry for the noise!
Caveats
The new analytics database module has the same security group rules as the old one, which will likely become confusing over time. For example, the new analytics database module has an ingress rule for the Oracle database... which it definitely does not need. We should pull those concerns apart over time.
Testing