[Issue 1541] Ran make lint on analytics folder

[coilysiren]

Summary

Relates to #1541

Time to review: 2 mins

Changes proposed

I ran make lint then committed most of the results. I didn't commit all of the results because this isn't my code and so I don't want to overstep. Which is to say, make lint produced even more changes that you don't see in this PR. I think it would ideally be the responsibility of the code author(s) to address those changes.

Context for reviewers

This PR is necessary due to CI not actually checking if the lining is being done. See #1541 for more details.

[widal001]

@coilysiren Can you also update the black and ruff checks in the make lint command to this:

$(POETRY) run black src tests --check
$(POETRY) run ruff check src tests --fix --exit-non-zero-on-fix

It looks like the CI checks exited with a 0 because these were auto-fixed

[widal001]

Thanks for re-running these checks locally to pick up the changes!

Can you also update the ruff and the black lines in make lint to this so that auto-fixed errors exit with non-zero status:

$(POETRY) run black src tests --check
$(POETRY) run ruff check src tests --fix --exit-non-zero-on-fix

[coilysiren]

@coilysiren Can you also update the black and ruff checks in the make lint command to this:

@widal001 I have a ticket for that, here: #1541

I want it to be its own PR since its going to merge conflict with #1538 which is already in progress