[Issue #1546] Deploy Analytics folder to AWS ECR #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Mar 27, 2024
| @@ -0,0 +1,59 @@ | |||
| data "aws_iam_role" "github_actions" { | |||
There was a problem hiding this comment.
Copied from infra/api/build-repository/main.tf, verbatim with no changes.
coilysiren
commented
Mar 27, 2024
| @@ -0,0 +1,38 @@ | |||
| name: Deploy Analytics | |||
There was a problem hiding this comment.
Copied from .github/workflows/cd-api.yml
coilysiren
changed the title
coilysiren
requested review from
aplybeah,
acouch,
chouinar and
SammySteiner
as code owners
coilysiren
commented
Mar 28, 2024
| analytics-checks: | ||
| name: Run Analyics Checks | ||
| uses: ./.github/workflows/ci-analytics.yml | ||
| secrets: inherit |
There was a problem hiding this comment.
Tests were broken before I added this line
secrets: inherit
coilysiren
commented
Mar 28, 2024
Comment on lines
+21
to
+27
| # This variable is slightly misnamed. It should really be called "has_migrations". | ||
| # It controls whether or not the `run-database-migrations.sh` script tries to run database | ||
| # migrations. The entire analytics application is going to have its schema controlled | ||
| # via ETL jobs, so we don't need to run migrations in the same way as the API. | ||
| output "has_database" { | ||
| value = false | ||
| } |
There was a problem hiding this comment.
I don't intend on updating the variable name. It seems fine to just document the issue here.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1546
Time to review: 5 mins
Changes proposed
infra/analyticscd-analyticsscript that I used to confirm that the ECR repository push was workingContext for reviewers
The PR was like 95% copy pasting
Testing
https://us-east-1.console.aws.amazon.com/ecr/repositories/private/315341936575/simpler-grants-gov-analytics?region=us-east-1