[Issue #1541] Fail CI when there are outstanding linter changes #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Apr 1, 2024
| @@ -184,15 +184,9 @@ def _isolate_data_for_this_sprint(self) -> pd.DataFrame: | |||
|
|
|||
| # """ | |||
There was a problem hiding this comment.
ruff made these changes. This is a good reminder not to leave large code blocks commented out like this, its "unsafe"
coilysiren
commented
Apr 1, 2024
| @@ -10,7 +10,9 @@ | |||
|
|
|||
|
|
|||
| def get_daily_tix_counts_by_status( | |||
There was a problem hiding this comment.
black made these changes
coilysiren
changed the title
coilysiren
requested review from
acouch,
aplybeah,
chouinar and
SammySteiner
as code owners
chouinar
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1541
Time to review: 2 mins
Changes proposed
Splits
lintinto:Their purposes are explained inline
Context for reviewers
See #1541