[Issue #1593]: Add eligibility and category filters #1613
Conversation
rylew1
requested review from
andycochran,
acouch and
SammySteiner
as code owners
rylew1
changed the title
|
|
||
| if (value) { | ||
| values.add(value); | ||
| } |
There was a problem hiding this comment.
just one function that all filter getters below can use
rylew1
requested review from
andycochran and
chouinar
and removed request for
andycochran
| formRef: React.RefObject<HTMLFormElement>; | ||
| } | ||
|
|
||
| export default function SearchFilterEligibility({ |
There was a problem hiding this comment.
Note that I did modify the naming on a few of these to be shorter as the existing values were a bit long to have as a constant.
You can see the original values on https://grants.gov/system-to-system/grantor-system-to-system/schemas/grants-funding-synopsis#EligibleApplicantTypes
For example: Nonprofits having a 501(c)(3) status with the IRS, other than institutions of higher education became nonprofits_non_higher_education_with_501c3. The former might be better for the label on the front-end.
There was a problem hiding this comment.
@andycochran I'm going to use the longer one for the label here per @chouinar's suggestion:
If it's an issue its a quick revert. And do we want to double check the other labels are all correct?
Summary
Fixes #1593
Time to review: 5-10 mins
Changes proposed
Context for reviewers
categoryin the frontend becomesfunding_categoryfor the API requestelgibilityin the frontend becomesapplicant_typefor the API requestScreen.Recording.2024-04-02.at.6.06.24.PM.mov