Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1548] Update Oracle SFN logs #1615

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[Issue #1548] Update Oracle SFN logs #1615

merged 1 commit into from
Apr 3, 2024

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Apr 3, 2024

Summary

Relates to #1548

Time to review: 1 mins

Changes proposed

  • added aws_cloudwatch_log_group to fix an error:

Error: creating Step Functions State Machine (...): InvalidLoggingConfiguration: Invalid Logging Configuration: The CloudWatch Logs Resource Policy size was exceeded. We suggest prefixing your CloudWatch log group name with /aws/vendedlogs/states/.

This error occurs periodically (eg. not every time) when trying to deploy this configuration

Context for reviewers

This change originated in #1604

@aplybeah
Copy link
Contributor

aplybeah commented Apr 3, 2024

Non-blocking Q: Do you think its worth following the suggestion in the error?

We suggest prefixing your CloudWatch log group name with /aws/vendedlogs/states/
Granted this looks like a one-off since this isn't consistently triggered.
@coilysiren

@coilysiren
Copy link
Collaborator Author

@aplybeah

Non-blocking Q: Do you think its worth following the suggestion in the error?

That's what this PR does, right? ^^

@aplybeah
Copy link
Contributor

aplybeah commented Apr 3, 2024

@coilysiren ah yes, I need to be better about reading

@coilysiren coilysiren merged commit bc29881 into main Apr 3, 2024
7 checks passed
@coilysiren coilysiren deleted the sfn-oracle-logs branch April 3, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants