Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1918]: Add GA4 id to Dev #1927

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

btabaska
Copy link
Collaborator

@btabaska btabaska commented May 6, 2024

Summary

Fixes #{1918}

Time to review: 2 mins

Changes proposed

Removed conditional on running Google Analytics so we can now run on Test and Dev
Added GA4 ID for Dev portal to env
Removed GTM ID for Dev and Prod as it is deprecated and no longer needed
Updated Pages router to use new <GoogleAnalytics component API

Context for reviewers

Prerequisite to being able to test GA4 work in dev

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Copy link

github-actions bot commented May 6, 2024

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 83.89% 854/1018
🟡 Branches 64.9% 220/339
🟡 Functions 75.34% 165/219
🟢 Lines 83.89% 797/950

Test suite run success

166 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from cd6be16

@btabaska btabaska merged commit 184f153 into main May 6, 2024
10 checks passed
@btabaska btabaska deleted the btabaska/1918-add-ga4-tag-to-dev branch May 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants