[Issue #1965]: Reintroduce totalPages to Pagination component #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
changed the title
rylew1
changed the title
rylew1
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 84.11% | 868/1032 |
| 🟡 | Branches | 65.01% | 223/343 |
| 🟡 | Functions | 75.58% | 164/217 |
| 🟢 | Lines | 84.15% | 807/959 |
Test suite run success
164 tests passing in 56 suites.
Report generated by 🧪jest coverage report action from 481a00c
rylew1
commented
May 10, 2024
| position: PaginationPosition; | ||
| searchResultsLength: number; | ||
| } | ||
|
|
||
| const MAX_SLOTS = 5; | ||
| const MAX_SLOTS = 7; |
andycochran
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1965
Time to review: 5 min
Changes proposed
Fixing the size of the pagination and overflow issues around the 600px viewport width will be done in a separate effort
Screen.Recording.2024-05-09.at.3.58.45.PM.mov