-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #1937] Translate Loading component text #2186
Conversation
…al for non-search loading translation as well Fixes #1937
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 90.6% | 790/872 |
🟡 | Branches | 71.79% | 224/312 |
🟢 | Functions | 87.89% | 167/190 |
🟢 | Lines | 91.27% | 742/813 |
Test suite run success
178 tests passing in 54 suites.
Report generated by 🧪jest coverage report action from e73407f
Looks good, think you need to add |
I think we landed in a better place here now. |
Follow up for further improvements to this component #2201 |
Summary
Fixes #1937
Time to review: 5 mins
Changes proposed
Implemented the translation library for the text on the Search loading spinner
Context for reviewers
This component is currently under the Search page, but seems like we'd likely reuse it elsewhere. Since file moves are weird to PR and revert I wanted to get more input before moving stuff around.
Additional information
Tested by implementing Storybook for this component