Maybe very important!!! Fix embedding error #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asyncio.as_completed() function does not guarantee that the results are ordered
When using this project, I found that the entities and relationships of the recall were somewhat related to the low-level keywords and the high-level keyword, but it was not very related, and I felt that the ability of the vector model was not fully utilized, it maybe a strange problem.
I looked at the code of inserting vectors and found problem.
asyncio.as_completed
is used incorrectly,asyncio.as_completed
results are not returned in the order in input tasks, but in the order in which the tasks were completed. I changed to useasyncio.gather
to make sure the results were orderly. And ensure thattqdm
works properly.This code need
asyncio.as_completed
results were orderlyLightRAG/lightrag/storage.py
Lines 110 to 112 in b7552f3