Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA NamingSystems #23

Closed
rockphotog opened this issue Feb 4, 2022 · 5 comments · Fixed by #27
Closed

QA NamingSystems #23

rockphotog opened this issue Feb 4, 2022 · 5 comments · Fixed by #27
Assignees
Labels
QA Quality assurance

Comments

@rockphotog
Copy link
Member

QA og sette draft til active

https://github.com/HL7Norway/kodeverk/tree/main/input/fsh/namingsystems

@rockphotog rockphotog added the QA Quality assurance label Feb 4, 2022
@thomiz
Copy link
Member

thomiz commented Feb 4, 2022

De andre no-basis NamingSystem benytter ikke no-basis-xxx formatet men har uri som dette:
http://hl7.no/fhir/NamingSystem/HPR

HPR

Sjekk ut disse DSTU2 profilene da:
HL7 Norge DSTU2

@thomiz
Copy link
Member

thomiz commented Feb 4, 2022

Skal vi legge disse inn i no-basis? @rockphotog

@thomiz
Copy link
Member

thomiz commented Feb 4, 2022

Eller ser det greit ut, men vi må kanskje endre URI'ene

@rockphotog
Copy link
Member Author

Jeg har egentlig prøvd å bygge de over samme lest, hvis du f.eks. ser på
https://github.com/HL7Norway/kodeverk/blob/main/input/fsh/namingsystems/no-basis-apotekenes-konsesjonsnr.fsh
og HPR som du peker på, men ser at jeg har truffet der og bommet grovt på de to andre.

De to avvikene:
http://hl7.no/fhir/NamingSystem/no-basis-her-id -> http://hl7.no/fhir/NamingSystem/HERid (eller helst "herid", synes mixed capitals er rotete...)
http://hl7.no/fhir/NamingSystem/no-basis-resh-id -> http://hl7.no/fhir/NamingSystem/RESHid

For org.nr har jeg funnet denne: http://data.brreg.no/begrep/28155
Men det er ID'en for begrepet, som kan være avvikende som konsept-id/namespace -- men jeg tror det vil fungere godt til vårt formål. Vi får ta en telefon, i mellomtiden lager jeg en versjon bygd på data.norge.no.

Kilde: https://data.norge.no/concepts/f6639f5e-280e-4dbb-991e-3faca3bf622c

@rockphotog
Copy link
Member Author

rockphotog commented Feb 4, 2022

Kladder på orgnr her:
(slettet)

EDIT: Slått de sammen, alt er i qa-namingsystem-branch:
https://github.com/HL7Norway/kodeverk/tree/qa-namingsystem-23/input/fsh/namingsystems

rockphotog pushed a commit that referenced this issue Feb 4, 2022
rockphotog pushed a commit that referenced this issue Feb 4, 2022
rockphotog pushed a commit that referenced this issue Feb 4, 2022
rockphotog pushed a commit that referenced this issue Feb 4, 2022
rockphotog pushed a commit that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality assurance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants