-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
实现 #2969: 启动前日志列出mods目录的jar文件 #3125
base: main
Are you sure you want to change the base?
实现 #2969: 启动前日志列出mods目录的jar文件 #3125
Conversation
你想修改可以向他的 PR 分支提出新的 PR,不要把别人的 PR 关了然后自己拿来开 PR。 |
当事人的 PR 提供的代码已经几乎被全部移除。介于当事人的努力依然值得尊重,我并没有完全在 Git 层面移除他的提交。因此,当本 PR 合并后,当事人依然会有 Co-Author 信息 EDIT: 换而言之,这不是修改,而是重写 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the refactored code and it looks good.
Thanks to the fact that the log files are stored in UTF-8 encoding, CJK characters can also be displayed normally. For disabled mods, mods replaced during updates, and mods with different suffixes (tested with .zip
and .litemod
), they can also be displayed normally.
Thanks for your testing. Using |
…e3094/pr3094/support-2969
Close #2969