Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3199: 运行在 Java 8 上时游戏安装界面卡片布局的问题 #3201

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Glavo
Copy link
Member

@Glavo Glavo commented Jul 28, 2024

No description provided.

@Glavo
Copy link
Member Author

Glavo commented Jul 28, 2024

@burningtnt 你加的这行代码是为了解决什么问题?移除它后我也没发现产生了什么问题。

@3gf8jv4dv
Copy link
Contributor

@burningtnt 你加的这行代码是为了解决什么问题?移除它后我也没发现产生了什么问题。

Is this what you are referring to?

holder.add(FXUtils.onWeakChangeAndOperate(pane.widthProperty(), v -> FXUtils.setLimitHeight(pane, v.doubleValue() * 0.7)));

#3117 (comment)

@burningtnt
Copy link
Member

burningtnt commented Jul 29, 2024

这一行是为了限制每一个卡片的宽高比。
每一个卡片的宽是由界面确定的,而原先高是由其内容决定的。加了这行代码后可以让高间接锁定

@Glavo
Copy link
Member Author

Glavo commented Jul 29, 2024

这一行是为了限制每一个卡片的宽高比。 每一个卡片的宽是由界面确定的,而原先高是由其内容决定的。加了这行代码后可以让高间接锁定

如果删掉它的行为和以前是一致的,那我先回退了。

@burningtnt
Copy link
Member

burningtnt commented Jul 29, 2024

这一行是为了限制每一个卡片的宽高比。 每一个卡片的宽是由界面确定的,而原先高是由其内容决定的。加了这行代码后可以让高间接锁定

如果删掉它的行为和以前是一致的,那我先回退了。

我觉得这是 JavaFX 内部宽高计算的问题。你要不尝试一下给这个地方改成 onWeakChange?

@Glavo
Copy link
Member Author

Glavo commented Jul 29, 2024

onWeakChange 倒是可行,我先推一个更新看看吧,不行再回退。

@Glavo Glavo merged commit 47cc9eb into HMCL-dev:main Jul 29, 2024
2 checks passed
@Glavo Glavo deleted the ui branch July 29, 2024 07:46
@burningtnt
Copy link
Member

有在其他版本的 Java 上测试过吗?

@3gf8jv4dv
Copy link
Contributor

有在其他版本的 Java 上测试过吗?

Java 21 looks fine.

@Glavo
Copy link
Member Author

Glavo commented Jul 29, 2024

有在其他版本的 Java 上测试过吗?

简单测过,看起来是正常的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants