Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复模组详情页图标问题 #3227

Merged
merged 15 commits into from
Aug 24, 2024
Merged

修复模组详情页图标问题 #3227

merged 15 commits into from
Aug 24, 2024

Conversation

zkitefly
Copy link
Member

@zkitefly zkitefly commented Aug 12, 2024 •
edited
Loading

@burningtnt burningtnt mentioned this pull request Aug 12, 2024
Closed
@zkitefly
Copy link
Member Author

遇到了个问题，为啥获取到的 icon 总是长宽为 0 的，不理解

@burningtnt qvq

@burningtnt
Copy link
Member

JavaFX 的图片是异步加载的。你可以看 FXUtils::newRemoteImage，有相关代码。

@Glavo Glavo merged commit 9b5445b into HMCL-dev:main Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burningtnt burningtnt burningtnt requested changes

@Glavo Glavo Glavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zkitefly @burningtnt @Glavo