Make Element immutable, rework its constructor, add some precompiles
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlikely as it is that someone relies on the mutability of `Element`, this is a breaking change, so also bump minor version.
martinholters
force-pushed
the
mh/rework-element
branch
from
9f8a5e4
to
822ddfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
Elementtype immutable and reworks its constructor for better inferability. Combined with a bunch ofprecompilecalls for common elements, this reduces the time for the first call tosuperover(Circuit)after includingexamples/superover.jlby almost 30% (on recent Julia versions, a little less gain on older Julia).As making
Elementimmutable is, strictly speaking, breaking, the minor version is bumped and while at it, deprecations are removed.