Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance 2022 Queries #2974

Merged
merged 47 commits into from
Aug 18, 2022
Merged

Performance 2022 Queries #2974

merged 47 commits into from
Aug 18, 2022

Conversation

konfirmed
Copy link
Contributor

@konfirmed konfirmed commented Jun 15, 2022

Progress on #2890

Queries:

Web Getting Right (Not Custom)

  • % of sites that are using priority as an attribute on LCP element
  • % of sites where the LCP is element is preloaded

Web Getting Wrong

Gaming the Metrics (Custom)

  • Filtering for synthetic tests (does not catch hex codes, see https://www.simpleskincare.in/ for example)
  • LCP Animation & Overlay Hack
  • LCP Svg Overlay Hack
  • CLS Animation Hack
  • FID iFrame Hack

Antipatterns (Custom)

  • LCP Lazy Loaded

Antipatterns (Not Custom)

  • Are LCP Image Elements Responsive
  • LCP Element Resource Delay
  • TTFB by Category
  • Domain Sharding
  • FID Double Tap to Zoom Disabled
  • FID / INP Long Task Data (let's pick either FID or INP)

Web Vitals

  • By Device
  • By Country
  • By Network connection
  • By Rank
  • By Rank and device

@rviscomi rviscomi marked this pull request as draft June 15, 2022 14:31
@rviscomi rviscomi added the analysis Querying the dataset label Jun 15, 2022
@rviscomi rviscomi added this to the 2022 Analysis milestone Jun 15, 2022
@foxdavidj
Copy link
Contributor

@konfirmed How are the queries coming along?

@mel-ada
Copy link
Contributor

mel-ada commented Jul 26, 2022

I've added a query list in the README, this is taken directly from the Metrics section in the linked planning doc!

@mel-ada mel-ada mentioned this pull request Aug 1, 2022
6 tasks
@mel-ada
Copy link
Contributor

mel-ada commented Aug 9, 2022

I've removed this section from the PR description and replaced it with the README since it is mostly overlap. Leaving it here for reference:
WIP

Core Web Vitals Performance Past

  • Changelog

Core Web Vitals Performance Present

What is the web getting right? - Priority hints

  • What is the effect on LCP?
  • % of sites that are using priority as an attribute
  • % of sites where the LCP is element is preloaded,
    -- [ ] and what is the order vs other requests that are preloaded

What is the web getting wrong?

  • Gaming the metrics
  • Causes of slow performance

Core Web Vitals Performance Present

  • INP
  • Bfcache®

@foxdavidj
Copy link
Contributor

foxdavidj commented Aug 9, 2022

@mel-ada are so these are not additional metrics that need to be queried? But fully covered by what is listed in the description above?

@25prathamesh @konfirmed How possible is it to have the queries written and added to the spreadsheet by the end of the week (Aug 12th)?

Also i see that you're adding multiple metrics in one sheet:

Screen Shot 2022-08-09 at 09 03 21

Please put each metric in its own sheet, with the sheet name being the same as the query file name

@25prathamesh
Copy link
Contributor

HI @foxdavidj @mel-ada @konfirmed @siakaramalegos

Thanks for the feedback I will put each metric in its own sheet, with the sheet name being the same as the query file name.

@konfirmed has already committed queries for the "What is the web getting right? - Priority hints" section, he will update data in the sheet

4 queries are still pending from Antipatterns Section which are LCP Element Resource Delay, TTFB by Category, Domain Sharding, and FID Double Tap to Zoom Disabled

I am already working on TTFB by Category query which I will commit to in the next 2 days, having limited time during weekdays I will not able to complete the Rest of the 3 queries by 12 Aug. I will try to finish them on 14-15 Aug.

@mel-ada
Copy link
Contributor

mel-ada commented Aug 9, 2022

@foxdavidj Yes, all queries needed are captured in the PR description. This comment is the original PR description and can be disregarded, it's for reference incase the analysts still needed it.

@rviscomi
Copy link
Member

@konfirmed @25prathamesh how can I help? We need to wrap this up ASAP so @mel-ada can write the draft, which is due in a couple of weeks.

@rviscomi rviscomi marked this pull request as ready for review August 17, 2022 17:40
@rviscomi
Copy link
Member

I've added the remaining queries, tidied up the results sheet, and added charts where applicable. Some metrics have a single value for both desktop and mobile, and these work best as simple "big number" figures rather than charts, so I didn't make any.

Let's get the PR merged and iterate on the queries if needed. @mel-ada PTAL at the results sheet and let us know if you have any questions. For some of the more complex results I added some analyst notes in the form of comments and highlighted the cells in yellow.

Sorry for the delay, hopefully it was worth the wait as these results are super interesting. Looking forward to reviewing your draft!

@rviscomi rviscomi merged commit cbfe6da into main Aug 18, 2022
@rviscomi rviscomi deleted the peformance-2022-sql branch August 18, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants