-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Mixtral quantization using INC #267
Conversation
jenkins vllm-perf run of this branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dudilester ,
Your changes look fine but the testing is insufficient.
- your branch does not contain the latest flat_pa changes Port flat PA from habana_next to habana_main #169 . Please rebase your branch and rerun tests.
- gerrit change used in your tests installs custom inc binary. Please make sure that all required changes are merged and do not install any custom binaries.
Thanks!
3c21080
to
61cc9a3
Compare
Hi @szutenberg, Thank you for the review. https://tf-jenkins-ctrl01.habana-labs.com/job/static-benchmarks/job/vllm-benchmarks/195/ {"mlperf-moe/mixtral-8x7b-tp1-fp8": {"rouge1": 45.9205, "rouge2": 23.7295, "rougeL": 30.8274, "rougeLsum": 42.9159, "gsm8k": 72.66, "mbxp": 57.58, "gen_len": 4163594, "gen_num": 15000, "gen_tok_len": 2132769, "tokens_per_sample": 142.2, "accuracy": 95.71, "valid": true, "warmup_duration": 512.0, "test_duration": 4143.0, "eval_duration": 243.0}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks @dudilester 👍
This reverts commit acf7d54.
No description provided.