Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hossein-w3-JavaScript #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hossein-w3-JavaScript #21

wants to merge 2 commits into from

Conversation

Hossein-Kelisa
Copy link

No description provided.

elias-soykat
elias-soykat reviewed Dec 13, 2024
View reviewed changes
1-JavaScript/Week3/assignment/ex2-mondaysWorth.test.js Outdated
// TODO complete this function
function computeEarnings(mondayTasks, hourlyRate) {
const euroSign = '\u20AC';
const workingHours =
Copy link

@elias-soykat elias-soykat Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the map array function to take out the duration time for each task.

I think you do not meet the requirements. you should use map instead of reduce. if you face any issue then feel free to share it over slack :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Elyas,
Thank you for your feedback, I've updated the code for ex2-mondaysWorth.js to use the map function as requested. The changes are now pushed, and the pull request has been updated. Please let me know if there's anything else to adjust!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@Hossein-Kelisa
Copy link
Author

Hi Elyas,
Thank you for your feedback, I've updated the code for ex2-mondaysWorth.js to use themapfunction as requested. The changes are now pushed, and the pull request has been updated. Please let me know if there's anything else to adjust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elias-soykat elias-soykat elias-soykat left review comments

Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hossein-Kelisa @elias-soykat