Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elias-hackyourtemperature #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EliasRajha
Copy link

@EliasRajha EliasRajha commented Sep 27, 2024

I have made changes you can review it :)

…the PR. Fixed indentation to make the code clearer. Moved app.use(express.json()); to be grouped logically with other setup code.
@EliasRajha EliasRajha changed the title Moved unrelated files to a new branch and removed those commits from … Elias-hackyourtemperature Sep 27, 2024
Copy link

@dyaboykyl dyaboykyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. Nice job!

import express from 'express';
const app = express();

app.use(express.json()); // Moved this line up

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor: Comments about the PR itself should not be included in the code (e.g. "Moved line up", "Fixed indentation", etc.")

You can include those types of comments in the PR description or you can even comment on your own PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants