Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beimnet w2 nodejs #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions assignments/hackyourtemperature/__tests__/app.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import app from '../app.js';
import supertest from 'supertest';

const request = supertest(app);

describe('POST /weather', () => {
it('should return 400 if cityName is missing', async () => {
const response = await request.post('/weather').send({});
expect(response.status).toBe(400);
expect(response.body.error).toBe('cityName is required');
});

it('should return 404 if cityName is invalid', async () => {
const response = await request
.post('/weather')
.send({ cityName: 'invalidCity' });
expect(response.status).toBe(404);
expect(response.body.error).toBe('city not found');
});

it('should return temperature if cityName is valid', async () => {
const response = await request
.post('/weather')
.send({ cityName: 'London' });
expect(response.status).toBe(200);
expect(response.body.weatherText).toContain('The temperature in London is');
});
});
40 changes: 40 additions & 0 deletions assignments/hackyourtemperature/app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import fetch from 'node-fetch';

import express from 'express';

const API_KEY = '5b880f4ee3e43bab62bd1d03019f09c2';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is being used again (it's also defined in key.js). It's always preferable to keep security keys separate from the actual code as they are sensitive information. In fact, in a production setting, you would not even check the api key into github as that could expose it as well.

I won't block on this since the code is working well and you've move on the the next module, but something to keep in mind!


const app = express();
app.use(express.json());

app.get('/', (req, res) => {
res.send('hello from backend to frontend');
});

app.post('/weather', async (req, res) => {
const cityName = req.body.cityName;
const url = `http://api.openweathermap.org/data/2.5/weather?q=${cityName}&appid=${API_KEY}&units=metric`;
if (!cityName) {
return res.status(400).json({ error: 'cityName is required' });
}
try {
const response = await fetch(url);
const data = await response.json();

if (data.status === '404') {
return res.status(404).json({ weatherText: 'city is not found' });
} else if (!response.ok) {
return res.status(response.status).json({ error: 'city not found' });
}

const temperature = data.main.temp;

res.status(200).json({
weatherText: `The temperature in ${cityName} is ${temperature}°C`,
});
} catch (error) {
res.status(500).json({ error: 'server error' });
}
});

export default app;
12 changes: 12 additions & 0 deletions assignments/hackyourtemperature/babel.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
module.exports = {
presets: [
[
'@babel/preset-env',
{
targets: {
node: 'current',
},
},
],
],
};
6 changes: 6 additions & 0 deletions assignments/hackyourtemperature/jest.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
transform: {
'^.+\\.js$': 'babel-jest',
},
transformIgnorePatterns: [],
};
28 changes: 28 additions & 0 deletions assignments/hackyourtemperature/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"name": "hackyourtemperature",
"version": "1.0.0",
"description": "",
"main": "server.js",
"scripts": {
"test": "jest",
"start": "node server.js"
},
"type": "module",
"keywords": [],
"author": "",
"license": "ISC",
"dependencies": {
"express": "^4.21.1",
"express-handlers": "^1.0.0",
"node-fetch": "^3.3.2",
"nodemon": "^3.1.7"
},
"devDependencies": {
"@babel/core": "^7.25.8",
"@babel/preset-env": "^7.25.8",
"@babel/register": "^7.25.7",
"babel-jest": "^29.7.0",
"jest": "^29.7.0",
"supertest": "^7.0.0"
}
}
6 changes: 6 additions & 0 deletions assignments/hackyourtemperature/server.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import app from './app.js';

const port = 3000;
app.listen(port, () => {
console.log(`Server is running on http://localhost:${port}`);
});
1 change: 1 addition & 0 deletions assignments/hackyourtemperature/source/key.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const AIP_KEY = '5b880f4ee3e43bab62bd1d03019f09c2';
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"devDependencies": {
"jest": "^29.7.0",
"supertest": "^7.0.0"
}
}