-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodejs week2 hackyourtemprature #27
base: main
Are you sure you want to change the base?
Nodejs week2 hackyourtemprature #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Fatemeh, looking at your test cases I assume you have done the work correctly but something seems to have happened when committing your files so both server.js
and app.js
files are empty. Can you add them here so I can have a look, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add this file/folder to the project's git ignore list.
The idea behind loading sensitive details such as API keys from a dedicated file rather than hardcoding them directly into the application files is that the details then don't need to be checked into the project's repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for letting me know, I added this to the gitignore 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be missing the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be missing the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good in principle. However, I'll only be able to say with certainty once you commit also the contents of the app.js
file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, Michal. I have written the code, but I forgot to double-check that it has not been committed🤔 I have just discovered that I should go to the file command + s and then it would be somehow added the I should add it to git and commit that why the file was empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you for adding the missing files!
No description provided.