Oleksandr Week 1 Node JS #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durw4rd
reviewed
Sep 25, 2024
package.json
Outdated
There was a problem hiding this comment.
Seems the file structure got a bit mingled - the package.json file is outside of the app folder.
There was a problem hiding this comment.
Yes, you are right, I have to use unique package.json for each app, and not one package.json for all the apps.
durw4rd
reviewed
Sep 25, 2024
|
|
||
| app.post("/weather", (req, res) => { | ||
| const cityName = req.body.cityName; | ||
| res.json({ cityName }); |
There was a problem hiding this comment.
I didn't look into the assignments for the upcoming weeks yet so I don't know in which direction this project evolves. Nothing wrong with using the res.json() method for now, just be aware there is also the more versatile option res.send() if you need/want to send other data types: https://www.geeksforgeeks.org/difference-between-res-send-and-res-json-in-express/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.