Assignment w1 react HANNA MELNYK #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycons
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Good implementation 👍
- Functionality to display products and filter by categories is implemented
- Use of state hook
- Copied fake data into
srcfolder as instructed.
Requested improvements
- Clean up the displayed product names and category names
- Improve folder structure by moving components into a folder called
components. This structure improves maintainability. It's good to be able to recognise the difference between pages (stand alone) and components (re-usable)
| import { ProductList } from './ProductList'; | ||
|
|
||
| export const CategoryList = () => { | ||
| const [selectedCategory, setSelectedCategory] = useState(null); // Initialize state with null to show all products |
| const handleCategoryClick = (category) => { | ||
| if (selectedCategory === category) { | ||
| // If the clicked category is already selected, deselect it | ||
| setSelectedCategory(null); |
There was a problem hiding this comment.
Nice feature to toggle the selection on and off 👍
| return ( | ||
| <div> | ||
| {/* Category selection buttons */} | ||
| {categories.map((category, index) => ( |
There was a problem hiding this comment.
This could be a standalone component. Give it a try and see.
| <div className="product-grid"> | ||
| {filteredProducts.map((product) => ( | ||
| <div key={product.id} className="product"> | ||
| <img src={product.image} alt={product.title} /> |
There was a problem hiding this comment.
Good practice to use the alt attribute in web development 👍
| {filteredProducts.map((product) => ( | ||
| <div key={product.id} className="product"> | ||
| <img src={product.image} alt={product.title} /> | ||
| <h2>{product.title}</h2> |
| onClick={() => handleCategoryClick(category)} // Handle category click | ||
| className={selectedCategory === category ? 'active' : ''} | ||
| > | ||
| {category} |
|
Comments cleared! |
sycons
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.