Alishka-react-w1 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlorent
reviewed
Sep 14, 2024
There was a problem hiding this comment.
Nice work so far @Alishka-Space ! 👏 I do have a few comments about how it looks and works. Also, please for next time deploy it on Netlify (as per requirements) so I can also check it live 😄 This is the live example btw that you can use to make sure it looks as expected: https://hyf-react-w2-example.netlify.app.
- The page is not responsive enough. When I resize at some point there is not enough space and parts of the product are visible only when scrolling to the right. Please see if you can fix this with CSS.
- The categories are just pieces of text right now and it is not super clear they can be clicked (for example by making it a button). Please see if you can fix this as well by looking at the example.
- The layout keeps shifting when I select different categories. Ideally the title and categories are at the top of the page and the categories below, like the example.
| <div className="categories"> | ||
| {categories.map((category) => ( | ||
| <div key={category} className={'category-item ' + (category === selectedCategory ? 'category-selected' : '')}> | ||
| <h3 onClick={() => handleCategoryChange(category)}>{category}</h3> |
There was a problem hiding this comment.
⚒️
This will only trigger a category change if you click exactly on the title/text/h3. Please see if you can fix this that the whole div works 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.