Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nima-react-w2 #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nimasaghi-dev
Copy link

No description provided.

@Nimasaghi-dev
Copy link
Author

This is the link to Netlify.

@MaryRichelle MaryRichelle self-requested a review November 28, 2024 13:11
@MaryRichelle MaryRichelle self-assigned this Nov 28, 2024
Copy link

@MaryRichelle MaryRichelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall! 🌟

/>
<Route path="/product/:id" element={<ProductDetail />} />
</Routes>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I would suggest keeping the routes in App.js, but moving the rest of the logic into separate components.
Additionally, you can move the API logic into a separate file for better organization and maintainability.

<h2>{product.title}</h2>
<p>{product.description}</p>
<p>Price: ${product.price}</p>
<button onClick={() => window.history.back()}>Go Back</button>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏
nice
you can also try react router useNavigate api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants