Tugbanur-React week 3 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryRichelle
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Great job overall! The fetchData function is well-written, and error handling looks good. Using setTimeout to add a delay works, but it might be better to remove it or make the loading time match the actual fetch time. The code is clean and easy to understand—well done!
| setTimeout(() => { | ||
| setData(result); | ||
| setLoading(false); | ||
| }, 1000); |
There was a problem hiding this comment.
Good implementation overall, and the fetchData function works well. However, using setTimeout to simulate a delay might not be the best approach for production. It could be better to handle the loading state dynamically based on the actual fetch duration or remove the artificial delay altogether. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.