Assignment-week3-React-Alia Taher #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryRichelle
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Nice work overall!
I noticed that the useFetch hook is in the main folder. It would be better to create a useFetch.js file and move it to a hooks folder. Also you can move context files into cotext folder. This will help keep the project organized and make it easier to manage.
| <div className="Fav-page"> | ||
| <h2>Favorites</h2> | ||
| <NavLink to="/favorites" name={"Favorites"} className={"fav-link"} /> | ||
| <NavLink to="/" name={"Products"} className={"products-link"} /> |
There was a problem hiding this comment.
Nice work! I noticed you're repeating the same code for the navbar on all pages. It would be great if you could refactor this and make the navbar appear consistently across all pages by creating a single navbar component in React.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.