Oleksandr week 1 react assignment #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robvk
requested changes
Nov 13, 2024
There was a problem hiding this comment.
A good start! Some general comments:
- I like your component splitting, seems very logical!
- If React doesn't need to 'react' to something then it should not be in the state. Remember that every change in state causes a rerender so we want to minimize it if possible
- In the example I can
deselecta category by clicking on it a second time to get the full list again, but I can't in yours. Can you look into this and see if you can add that feature?
Good luck!
|
|
||
| if (selectedCategory) { | ||
| filteredProducts = products.filter( | ||
| (product) => product.category === selectedCategory.slice(6) |
| import { useState } from "react"; | ||
|
|
||
| const CategoryList = ({ categories, setCategory }) => { | ||
| const [selectedCategory, setSelectedCategory] = useState(null); |
There was a problem hiding this comment.
You also have this state in your App component. Why are there two?
week1/project/ecommerce/src/App.jsx
Outdated
|
|
||
| function App() { | ||
| const [categories, setCategories] = useState(allCategories); | ||
| const [products, setProducts] = useState(allProducts); |
There was a problem hiding this comment.
You never set these state variables so I don't think you need to have them? If it never changes it doesn't need to be in the React ecosystem
|
Hello Rob, thank you for the feedback. I removed unnecessary states and added the |
robvk
approved these changes
Nov 14, 2024
|
Nice work! Good luck with week 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://thunderous-sfogliatella-b47fd5.netlify.app/