Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment Week2 <Ozlem Karaboga> #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OzlemKaraboga
Copy link

No description provided.

@sarlam sarlam self-requested a review August 19, 2024 08:51
@sarlam sarlam self-assigned this Sep 1, 2024
Copy link

@sarlam sarlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this week exercises
It seems you got how SQL works :)

My only remarks would be to make sure there is only the files for week2 in this Pull Request

university VARCHAR(255),
date_of_birth DATE,
h_index INT,
gender VARCHAR(10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small remarks, an ENUM instead of a VARCHAR could be easier to use in the future here

@@ -0,0 +1,50 @@
// Load the MySQL module
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file perfect, nice work!

@sarlam sarlam added the Approved label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants