Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M_Hajjar database w3 #22

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

M-Hajjar
Copy link

No description provided.

@sarlam sarlam self-assigned this Sep 1, 2024
Copy link

@sarlam sarlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part of the week 3 assignment looks really good, it seems you understood really well SQL and how to organize it well in JavaScript

It seems the last part of week3 is missing, the mongo db code

In addition could you make sure only week 3 is present in your pull request?

Comment on lines +33 to +34
- **food_code**: This column contains multiple values (e.g., "C1, C2") in a single field, which violates the requirement for atomic values.
- **food_description**: Similarly, this column contains multiple values (e.g., "Curry, Cake") in a single field.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, they are not the only column that brakes the first Normal Form, what about dinner_date

@M-Hajjar
Copy link
Author

Hallo Paul
big thanks for checking
my bad it seems that I have not added the MongoDB CRUD file

@sarlam
Copy link

sarlam commented Sep 12, 2024

Hallo Paul big thanks for checking my bad it seems that I have not added the MongoDB CRUD file

Hi,

It seems they were a mistake and you pushed the example mongodb code and not the homework one

Could you take a look at the homework/mongodb folder, make sure you did the exercises on Bob Ross episodes and push it?

@M-Hajjar
Copy link
Author

oh there was a homework file as well
Thanks for mentioning that

@sarlam
Copy link

sarlam commented Sep 30, 2024

Looks really good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants