-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment week 3 Hanna Melnyk #23
base: main
Are you sure you want to change the base?
Assignment week 3 Hanna Melnyk #23
Conversation
I think you forgot to git add the exercises from week 3. Currently it is showing only weeks 1 and 2. |
…ANNA-MELNYK-w3-databases
I've made updates, Week 3 exercises are now on HANNA-MELNYK-w3-databases branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good. Exercises 1, 2 and 3 are great. Congrats.
About the exercise 4, it is missing the env file example.
Check this:
You will need to figure out a way to get these .env variables into the process environment. This is almost always done using a library, but it is up to you to figure out which one this is and set it up correctly.
Now, we don't want this: await mongoose.connect('mongodb://127.0.0.1:27017/test');
Somehow we want to pass these variables, but not passing the real values, but enough information to help others to create it.
For example, for you the MongoDB is at mongodb://127.0.0.1:27017/test
, but for me it could be something different (like mongodb://192.168.0.10:27017/rafael)
The idea is that I can use your code without changing the source code, but only a configuration file.
@@ -0,0 +1,17 @@ | |||
## 1. What columns violate 1NF? | |||
- columns `food_code` and `food_description`. They contain multiple values, which violates atomic value rule of 1NF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. But also dinner_date
has multiple types.
- dinner | ||
- venue | ||
- food | ||
- dinner_food |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dinner food is not really a entity. This is a link (a M2M) that connect the 2 entities.
No description provided.