Assignment Week1 <Ozlem Karaboga> #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlam
reviewed
Aug 15, 2024
There was a problem hiding this comment.
The SQL part is absolutely perfect, you understood really well the language itself and it seems you can query data with ease.
I made some comments on the table design itself, they are none blocking as your SQL should work as is.
Unfortunately I could not run your code, one reason is I has an issue with my computer and no time to fix it, the other is your code is lacking a package.json so I can not run it online.
I trust you ran your code in your local machine
sarlam
reviewed
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.