Oleksandr databases week 3 assignment #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddoyediran
reviewed
Nov 5, 2024
| @@ -0,0 +1,39 @@ | |||
| 1. What columns violate 1NF? | |||
| - Column member_id must be unique | |||
| - dinner_date must be in in one format - date | |||
ddoyediran
reviewed
Nov 5, 2024
| @@ -0,0 +1,39 @@ | |||
| 1. What columns violate 1NF? | |||
| - Column member_id must be unique | |||
There was a problem hiding this comment.
member_id are unique just that some members had dinners more than once.
ddoyediran
reviewed
Nov 5, 2024
| try { | ||
| const createTables = ` | ||
| CREATE TABLE IF NOT EXISTS account ( | ||
| account_number INT AUTO_INCREMENT PRIMARY KEY, |
There was a problem hiding this comment.
For security reason, it might not be the best approach to use AUTO_INCREMENT for account. If the account_number is exposed to users, it could be predictable and potentially used for malicious purposes.
ddoyediran
reviewed
Nov 5, 2024
| const createTables = ` | ||
| CREATE TABLE IF NOT EXISTS account ( | ||
| account_number INT AUTO_INCREMENT PRIMARY KEY, | ||
| balance INT NOT NULL |
There was a problem hiding this comment.
To accurately represent monetary values, it's recommended to use a decimal data type instead of INT as follows balance DECIMAL(10, 2) NOT NULL.
ddoyediran
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.