Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment week 4 Asim #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Muatasim-Aswad
Copy link

No description provided.

@Muatasim-Aswad Muatasim-Aswad force-pushed the assignment_4 branch 5 times, most recently from d5bf384 to 65b3f2c Compare November 4, 2024 15:47
Copy link

@dyaboykyl dyaboykyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Well done

});
}

async function getNextCount(db, id) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you didn't need this function after all?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyaboykyl In version 1, I referenced account-changes and used it. However, I didn't delete it when I rewrote the embedded version as it seems a pattern I might use in another place.

Thank you for all the valuable feedback and info.

@dyaboykyl dyaboykyl self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants